Fix examples 2019 04 #7718
Merged
Fix examples 2019 04 #7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix missing comment on the code example - Fix to use double backslashes - Fix anchor and drive
- Remove dependency on `tempfile`
- expected named argument
maiha
commented
Apr 25, 2019
Sija
reviewed
Apr 25, 2019
Closed
- two more instances that need double backslash escapes as well
|
It seems that everything is fine. It's time to merge. 😺 |
straight-shoota
approved these changes
May 5, 2019
bcardiff
approved these changes
May 5, 2019
|
@maiha thank you so much for doing these PRs! It's really appreciated ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Congrats 0.28.0! Let's catch up the examples code too!
67167d960 Format: remove old code to format &.[] (#7699))For convenience, commits are divided file by file, so please apply squash merge.
Best regards,