Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compiler warnings opt-in #7661

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Make compiler warnings opt-in #7661

merged 2 commits into from
Apr 10, 2019

Conversation

bcardiff
Copy link
Member

Closes #7652 and Closes #7650.

Change compiler warnings to be opt-in. Will help gather feedback without a default noisy output for everybody.

@bcardiff bcardiff added this to the 0.28.0 milestone Apr 10, 2019
@bcardiff bcardiff changed the title Feature/warnings as opt in Make compiler warnings opt in Apr 10, 2019
@bcardiff bcardiff changed the title Make compiler warnings opt in Make compiler warnings opt-in Apr 10, 2019
@bcardiff bcardiff mentioned this pull request Apr 10, 2019
Open
@straight-shoota straight-shoota mentioned this pull request Apr 10, 2019
Closed
ysbaddaden
ysbaddaden reviewed Apr 10, 2019
View reviewed changes
Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's boring to have to specify -Wall all the time in C. I hope this is only temporary, and they'll be out in in 0.29 (they should already be). Want a clean build output? Fix your code, we even tell you how.

@bcardiff bcardiff merged commit 3793b10 into crystal-lang:master Apr 10, 2019
@j8r j8r mentioned this pull request Apr 12, 2019
Closed
@bcardiff bcardiff mentioned this pull request Apr 15, 2019
Merged
@bcardiff bcardiff deleted the feature/warnings-as-opt-in branch April 18, 2019 19:32
@Blacksmoke16 Blacksmoke16 mentioned this pull request Jun 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden left review comments

@RX14 RX14 RX14 approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:feature topic:compiler
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
5 participants
@bcardiff @ysbaddaden @asterite @straight-shoota @RX14