Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restriction update: generic vs path - specs #7580

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Restriction update: generic vs path - specs #7580

merged 2 commits into from
Apr 2, 2019

Conversation

bew
Copy link
Contributor

@bew bew commented Mar 23, 2019

  • Makes this work:
def foo(a : T) forall T
  1
end

def foo(a : Array(T)) forall T
  true
end

foo(Array(Int32).new) # => true
  • Adds some restriction specs for Path vs Path & Generic vs path
  • Simplify Metaclass vs Metaclass restriction implementation

@bew bew mentioned this pull request Mar 23, 2019
Merged
@asterite asterite added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels Apr 2, 2019
@asterite asterite added this to the 0.28.0 milestone Apr 2, 2019
@asterite asterite merged commit 67c257b into crystal-lang:master Apr 2, 2019
@bew bew deleted the restriction-update--generic-vs-path-and-add-specs branch April 2, 2019 12:00
@bew
Copy link
Contributor Author

bew commented Apr 2, 2019

Cool! thx for the review / merge!

@straight-shoota
Copy link
Member

Thanks for the PR =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bew @straight-shoota @asterite