Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting absolute paths #7560

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Fix formatting absolute paths #7560

merged 1 commit into from
Mar 17, 2019

Conversation

RX14
Copy link
Contributor

@RX14 RX14 commented Mar 16, 2019

Fixes #7559

@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter labels Mar 16, 2019
asterite
asterite reviewed Mar 16, 2019
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a method to check if a path is absolute

@Sija
Copy link
Contributor

Sija commented Mar 16, 2019

Any test for this?

@RX14
Copy link
Contributor Author

RX14 commented Mar 16, 2019

There weren't any tests for this command code before, and I can't be bothered to create a whole test harness for a bugfix

@RX14
Copy link
Contributor Author

RX14 commented Mar 16, 2019

@asterite I can't find that method.

@asterite
Copy link
Member

Sorry, my mistake, it exists in Ruby in Pathname

@straight-shoota
Copy link
Member

#5635 adds such a method.

@straight-shoota straight-shoota merged commit d4ded5c into crystal-lang:master Mar 17, 2019
@straight-shoota straight-shoota added this to the 0.28.0 milestone Mar 17, 2019
@straight-shoota
Copy link
Member

Thank you @RX14 !

urde-graven pushed a commit to urde-graven/crystal that referenced this pull request Mar 20, 2019
Merge branch 'master' of github.com:crystal-lang/crystal
cae4845 
* 'master' of github.com:crystal-lang/crystal:
  Change the font-weight used in Playground (crystal-lang#7552)
  Fix formatting absolute paths (crystal-lang#7560)
  Refactor IO::Syscall as IO::Evented (crystal-lang#7505)
  YAML: fix test checking serialization of slices for libyaml 0.2.2 (crystal-lang#7555)
  Let Array#sort only use `<=>`, and let `<=>` return `nil` for partial comparability (crystal-lang#6611)
  Update `to_s` and `inspect` to have similar signatures accross the stdlib (crystal-lang#7528)
  Fix restriction of valid type vs free vars (crystal-lang#7536)
  Rewrite macro spec without executing a shell command (crystal-lang#6962)
  Suggest `next` when trying to break from captured block  (crystal-lang#7406)
  Fix GenericClassType vs GenericClassInstanceType restrictions (crystal-lang#7537)
  Add human readable formatting for numbers (crystal-lang#6314)
  Add command and args to execvp error message (crystal-lang#7511)
  Implement Set#add? method (crystal-lang#7495)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite left review comments

@sdogruyol sdogruyol sdogruyol approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:formatter
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RX14 @Sija @asterite @straight-shoota @sdogruyol