Compiler: merge procs with the same arguments type and Nil | T return type to Nil return type #7527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type to Nil return type
bcardiff
approved these changes
Mar 8, 2019
straight-shoota
approved these changes
Mar 8, 2019
|
Incredible! That was so fast. Thank @asterite |
|
@paulcsmith Glad to help! 😊 It would be great if you can try it out in the code you have, if you are familiar with compiling the compiler (or maybe now there are nightlies that can make this easier). |
|
@asterite This PR ended up breaking Athena. (The commit before this was merged works fine). I'll see if i can come up with a reduced example of what is breaking. EDIT: It was prob broke before and this "fixed" it, I figured out the cause and the solution was something I was going to do anyway, so nvm. EDIT2: No, something is deff wrong, but im having trouble coming up some code. EDIT3: Made an issue, #7698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3655
The idea here is that a proc that returns any type
Tis compatible with a proc with the same argument types that returnsNil. The union type of those things is just the type of the proc that returnsNil, as in "in the general case we don't know anything about the value being returned".This is a rule that's currently being applied in a few places, this fixes the language to apply it in more (all?) places.