-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Unicode::CaseOptions enum #7513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @r00ster91 👍
Sorry, I don't understand this change. The enum is already documented. And the module too. |
But not publicy documented. It's not in the API documentation. I think stuff that can be used in public methods (like |
Oh, I see, this is the relevant line: require "./unicode/unicode" |
Co-Authored-By: r00ster91 <r00ster91@outlook.com>
@r00ster91 Am I missing something or is this still not actually visible in the online API docs? Specifically on https://crystal-lang.org/api/0.28.0/String.html#upcase%28options%3DUnicode%3A%3ACaseOptions%3A%3ANone%29-instance-method, the arg type isnt linked nor is |
Lines 7 to 8 in db9cb72
|
I guess nobody tried running |
Apparently not, that would do it. |
Seems like crystal/src/unicode/unicode.cr Lines 1 to 2 in db9cb72
|
I think the
Unicode::CaseOptions
enum should be publicly documented when it can be used in methods likeString#upcase
so you can easily see all the available case options.