-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Fiber::StackPool #7417
Extract Fiber::StackPool #7417
Conversation
dd1e4dd
to
0eae734
Compare
The circle/linux job failed, but the error seems unrelated:
|
We should note those CI errors and try to fix them. Lately I've been trying to get a CI that we can trust but it seems we are still missing a few cases. |
@asterite The hard thing is recognizing repeated instances of the same CI failure. A single random connection error simply isn't really worth noting because it could happen for many reasons and most of them are out of our control. |
Are we holding this just because of the CI failure? |
I just re-ran it. |
@asterite should be good to 🚢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a small request
Keeps stack operations (allocate, recycle, free) out of Fiber itself.
0eae734
to
15c65cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ready to merge?
Keeps stack operations (allocate, recycle, free) out of Fiber itself.
Just a mere extraction; not MT-safe but will be easy to add —e.g. use a mutex to protect the
deque.pop?
,deque.push
anddeque.shift?
calls.