Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Fiber::StackPool #7417

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

ysbaddaden
Copy link
Contributor

Keeps stack operations (allocate, recycle, free) out of Fiber itself.

Just a mere extraction; not MT-safe but will be easy to add —e.g. use a mutex to protect the deque.pop?, deque.push and deque.shift? calls.

@ysbaddaden
Copy link
Contributor Author

The circle/linux job failed, but the error seems unrelated:

1) TCPSocket fails when connection is refused
   Failure/Error: expect_raises_errno(Errno::ECONNREFUSED, "Error connecting to 'localhost:#{port}'") do
     Expected Errno but nothing was raised
   # spec/std/socket/tcp_socket_spec.cr:132

@asterite
Copy link
Member

We should note those CI errors and try to fix them. Lately I've been trying to get a CI that we can trust but it seems we are still missing a few cases.

@straight-shoota
Copy link
Member

@asterite The hard thing is recognizing repeated instances of the same CI failure. A single random connection error simply isn't really worth noting because it could happen for many reasons and most of them are out of our control.

@sdogruyol
Copy link
Member

Are we holding this just because of the CI failure?

@asterite
Copy link
Member

I just re-ran it.

@sdogruyol
Copy link
Member

@asterite should be good to 🚢

src/fiber.cr Outdated Show resolved Hide resolved
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small request

src/fiber.cr Outdated Show resolved Hide resolved
Keeps stack operations (allocate, recycle, free) out of Fiber itself.
@ysbaddaden ysbaddaden force-pushed the core/fiber-stack-pool branch from 0eae734 to 15c65cb Compare February 18, 2019 14:29
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to merge?

@straight-shoota straight-shoota added this to the 0.28.0 milestone Mar 5, 2019
@ysbaddaden ysbaddaden merged commit 2a65a98 into crystal-lang:master Mar 7, 2019
@ysbaddaden ysbaddaden deleted the core/fiber-stack-pool branch March 7, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants