Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows monotonic time bug #7377

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

domgetter
Copy link
Contributor

Performance frequency isn't necessarily 1 billion, so we now take the correct remainder.

For example, on my system it is only 10 million, so I only get 100 ns precision.

If this is considered "not minor", let me know and I can open an issue for this pull request.

Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a simple bug fix, and good as it is. Thanks!

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:time labels Feb 5, 2019
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @domgetter 👍

@sdogruyol sdogruyol merged commit 594ee7a into crystal-lang:master Feb 6, 2019
@sdogruyol sdogruyol added this to the 0.28.0 milestone Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants