Discourage the use of Bool#to_unsafe other than for C bindings #7320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependent codebases shouldn't be infested with the word "unsafe" even if this happens to do the job. Directly using ternary is clearer, too.
asterite
reviewed
Jan 17, 2019
This is a no-op for future-proofing
asterite
approved these changes
Jan 17, 2019
sdogruyol
approved these changes
Jan 18, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent codebases shouldn't be infested with the word "unsafe" even if this happens to do the job. Directly using ternary is clearer, too.