Compiler: only give named args errors when there's a single overload #7288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Jan 9, 2019
ysbaddaden
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7281
The compiler would try to determine if you already specified a named arguments solely based on the number of arguments, their position and the name of named arguments. But this might lead to false positives when there are multiple overloads.
For safety, this PR just triggers that other error message when there's a single overload, when it's safe to say so. In any other case the usual "no overload matches" is shown, which also lets you see which arguments you passed and which overloads are available. This can always be improved in the future, but for now it's better to not give misleading directions.