Enumerable#each_cons support for accepting deque as a reuse buffer #7233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
requested changes
Dec 29, 2018
bcardiff
approved these changes
Dec 29, 2018
RX14
reviewed
Dec 29, 2018
|
Should |
|
@straight-shoota it'd break a lot of code, since a lot of code only takes arrays. |
RX14
approved these changes
Jan 5, 2019
|
Should I rebase it down to three commits again? |
|
yeah |
straight-shoota
requested changes
Jan 5, 2019
d098cff to
9088392
Compare
9088392 to
901275f
Compare
938a961 to
987257f
Compare
straight-shoota
approved these changes
Feb 11, 2019
Deques can be more performant. Quite dramatically so if each_cons is given large n:s.
Deques can be more performant. Quite dramatically so if each_cons is given large n:s.
987257f to
1c23c29
Compare
|
(rebased) |
sdogruyol
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the restriction on
Enumerable#each_consandIterator#consto only accept arrays as a container to reuse. With this, it will be possible to use a Deque instead, for better performance.Also adds some missing tests in iterator_spec.cr
Solves #7189