Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL: Refactor context specs to reduce chances of failing #7202

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

bcardiff
Copy link
Member

Some of us use to have a foo.cr in the project root 🙈 and building it would make this spec fail.

ref: https://twitter.com/bcardiff/status/1075123585210085377

@bcardiff bcardiff force-pushed the refactor/ssl-context-spec branch from 587bd4c to 089a748 Compare December 18, 2018 21:40
@bcardiff bcardiff changed the title OpenSSL: Refactor const specs to reduce changes of failing OpenSSL: Refactor context specs to reduce changes of failing Dec 18, 2018
@bcardiff
Copy link
Member Author

How did const got typed instead of context !? 🤷‍♂️

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@sdogruyol sdogruyol merged commit f8346e0 into crystal-lang:master Dec 19, 2018
@sdogruyol sdogruyol added this to the 0.27.1 milestone Dec 19, 2018
@bcardiff bcardiff deleted the refactor/ssl-context-spec branch December 19, 2018 17:39
@bcardiff bcardiff changed the title OpenSSL: Refactor context specs to reduce changes of failing OpenSSL: Refactor context specs to reduce chances of failing Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants