Int128: fix how LLVM::Type.const_int emit 128 literals #7135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Dec 2, 2018
asterite
reviewed
Dec 2, 2018
| if !value.is_a?(Int128) && !value.is_a?(UInt128) && int_width != 128 | ||
| Value.new LibLLVM.const_int(self, value, 0) | ||
| else | ||
| encoded_value = UInt64[value & UInt64::MAX, (value >> 64) & UInt64::MAX] |
There was a problem hiding this comment.
But this allocates memory. Why not use static_array?
There was a problem hiding this comment.
AFAIK the reference is kept in llvm side. I couldn't find where the pointer was used to duplicate the data so I assume a reference was used. I could be wrong the documentation didn't said much.
There was a problem hiding this comment.
If it's kept in LLVM side then we must keep a reference on our side, otherwise the GC will collect it.
There was a problem hiding this comment.
It's copied: https://github.com/llvm-mirror/llvm/blob/master/lib/Support/APInt.cpp#L103
This should go on the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The llvm wrapper is not able to emit 128bits ints.
Instead of going the way #7093 did of using String. This will allow to use
LLVMConstIntOfArbitraryPrecisionmethod that accept the number as an array ofUInt64.