-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use read_file macro in Crystal::Config.version #7081
Conversation
@Sija do you want to update this with the |
@bcardiff first I'd like to discuss adding a raising variant and I'll do it after that if there won't be a consensus. |
I thought the consensus was that a single variant that cover all the cases was enough. |
@bcardiff I don't think it's settled since as I wrote in #6967 (comment) I believe having raising one is still more beneficial - raising outside of |
I began work on a variant of |
79f2924
to
2549629
Compare
Since #7094 has been merged, it seems it's ready to 🎲 (once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Sija 👍
@Sija would you mind pushing a rebase on master? |
2549629
to
2ced82b
Compare
@bcardiff Sure, done. |
Followup to #6967. If accepted, needs to be merged after
0.27.1
release.