Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hovering methods not working correctly #7022

Merged
merged 2 commits into from
Nov 7, 2018
Merged

Fix hovering methods not working correctly #7022

merged 2 commits into from
Nov 7, 2018

Conversation

wooster0
Copy link
Contributor

@wooster0 wooster0 commented Nov 3, 2018 •
edited
Loading

Fixes #7020

#6764 probably removed a bit too much and caused that when hovering a method in the inherited section, the detailed representation of the method is shown at the wrong place.

This is fixed by using position: relative which was originally applied by filter: blur(0);.

grafik

@RX14
Copy link
Contributor

RX14 commented Nov 3, 2018

This should use position: relative instead of filter: blur(0). Using filter does apply position: relative (lol wtf??), but the former is better to solve this bug.

@RX14 RX14 added this to the 0.27.1 milestone Nov 4, 2018
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler topic:tools labels Nov 4, 2018
sdogruyol
sdogruyol approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @r00ster91 👍

@sdogruyol sdogruyol merged commit fc07dd5 into crystal-lang:master Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler topic:tools
Projects
None yet
Milestone
0.27.1
Development

Successfully merging this pull request may close these issues.

HTML docs: hovering on an inherited method shows in the wrong place
4 participants
@wooster0 @RX14 @straight-shoota @sdogruyol