POSIX threads corrections & enhancements #6944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass the returned errnum to `Errno.new`. - Fix `Thread::Mutex.try_lock` to return true when the lock was acquired and false otherwise. - Add a spec for `Thread.current`.
Prevents deadlocks and undefined mutex behavior. > A thread attempting to relock this mutex without first > unlocking it shall return with an error. A thread attempting > to unlock a mutex which another thread has locked shall > return with an error. A thread attempting to unlock an > unlocked mutex shall return with an error. > > http://pubs.opengroup.org/onlinepubs/7908799/xsh/pthread_mutexattr_settype.html
Sija
reviewed
Oct 16, 2018
6b8a295 to
54d3217
Compare
|
RX14
reviewed
Oct 16, 2018
Configures thread condition variables to use the monotonic clock. Adds an overload for `#wait` that takes a timeout and executes the block when the timeout is reached, but doesn't when the condition variable is normally resumed. Refactors & enables Thread::ConditionVariable specs so they don't randomly hang.
54d3217 to
41045d6
Compare
|
Commits have been reordered, but since their sha didn't change, GitHub failed to notice it. |
|
@ysbaddaden the sha not changing is impossible... |
RX14
approved these changes
Oct 16, 2018
asterite
reviewed
Oct 16, 2018
| @@ -1,90 +1,89 @@ | |||
| require "spec" | |||
|
|
|||
| # These specs are marked as pending until we add | |||
| # support for parallelism, where we'll see if we | |||
| # need condition variables. | |||
There was a problem hiding this comment.
Since these were pending until somebody works on parallelism, and nobody did that yet, is it worth uncommenting these?
There was a problem hiding this comment.
Who said "nobody's working on MT" :)
But sure, I can keep the note.
There was a problem hiding this comment.
Oh, I meant all the specs. But if "somebody" ;-) is working on it, then this is fine.
bcardiff
approved these changes
Oct 16, 2018
|
Well, I have no idea why github doesn't understand reordered commits, then 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of corrections and small enhancements to POSIX threads integration:
Fixes:
errno;Thread::Mutex#try_lockreport whether the lock was acquired or not;Features:
Thread::ConditionVariable#wait;Thread.yieldto pass CPU time to another thread.