Improve support for parsing and formatting // #6927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was so lost while to debugging the formatter and the parser that ... bcardiff/crystal-ast-helper 🤓 Ugly code that helps cc: @makenowjust @asterite @ozra , in case you find it useful |
asterite
approved these changes
Oct 11, 2018
ysbaddaden
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6761
Required for #6891
and implements the same logic from 5cb2886 in the formatter.
Essentially improves the support for dealing with // as a integer division operator or empty regex is some corner cases by the parser and by the formatter.
Some of the specs are not needed per-se but I added while learning a bit of the formatter. I left them to add more coverage.