Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 4 typos in StringLiteral#gsub and #tr errors #6925

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Fix 4 typos in StringLiteral#gsub and #tr errors #6925

merged 1 commit into from
Oct 12, 2018

Conversation

wooster0
Copy link
Contributor

I came across this error message:

second arguent to StringLiteral#gsub must be a string, not CharLiteral

@bcardiff bcardiff added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler labels Oct 10, 2018
sdogruyol
sdogruyol approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @r00ster91 👍

@sdogruyol sdogruyol merged commit 058a495 into crystal-lang:master Oct 12, 2018
@sdogruyol sdogruyol added this to the 0.27.0 milestone Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@bcardiff bcardiff bcardiff approved these changes

@asterite asterite asterite approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler topic:stdlib:macros
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wooster0 @asterite @bcardiff @sdogruyol @RX14