Refactor Process in preparation for Windows support #6744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b8dceed to
3aebf51
Compare
bew
reviewed
Sep 19, 2018
ysbaddaden
reviewed
Sep 19, 2018
3aebf51 to
bb6b770
Compare
ysbaddaden
approved these changes
Sep 20, 2018
sdogruyol
approved these changes
Oct 1, 2018
|
Let's merge. |
|
I was planning on rebasing the windows part of the process refactor on top of this PR to make 100% sure that this PR was complete, but I'm moving back to university so havent had time :( I'm fine to merge this, but there's a very small but nonzero chance that there might be more amendments coming. |
bcardiff
approved these changes
Oct 1, 2018
jkthorne
reviewed
Oct 9, 2018
src/io/file_descriptor.cr
Outdated
| @@ -147,6 +147,7 @@ class IO::FileDescriptor < IO | |||
| end | |||
|
|
|||
| def reopen(other : IO::FileDescriptor) | |||
| return if self.fd == other.fd | |||
There was a problem hiding this comment.
should this return self?
will this introduce a Nil into the types that can be returned?
There was a problem hiding this comment.
Thanks for spotting! (this method should probably return nil but thats for another PR.
Having a single fork_internal method allows all callers to replace it with Crystal::System::Process.fork more easily. Also a breaking change as Process.fork no longer uses `with self yield self`.
This is useful when porting to Windows, as Crystal::System::Process.spawn will take args as an array. This is because Windows's CreateProcess doesn't take an argument vector.
Previously only errors from LibC.execvp were caught.
This means that Process.exec_internal is always passed an IO::FileDescriptor, moving non platform-specific code outside of exec_internal and into it's callers. Also fixes Process.exec crashing with a non-descriptive error when passed an IO that's not an IO::FileDescriptor. Redirect::Pipe is also disallowed for exec.
bb6b770 to
7a95390
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are best read in order, with their descriptions.