Refactor: Split socket_spec.cr into separate files #6700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
Sep 11, 2018
bew
reviewed
Sep 11, 2018
spec/std/socket/address_spec.cr
Outdated
| end | ||
|
|
||
| describe ".unix" do | ||
| it "creates a unix socket" do |
There was a problem hiding this comment.
why this landed to address_spec.cr ?
There was a problem hiding this comment.
after looking at the rest, it looks like you forgot to remove these specs from this file, ?
There was a problem hiding this comment.
Darn, looks like something went awry during rebase. These specs are supposed to be only in spec/std/socket/socket_spec.cr. I'll fix it.
spec/std/socket/address_spec.cr
Outdated
| end | ||
| end | ||
|
|
||
| it ".accept" do |
RX14
reviewed
Sep 11, 2018
|
All CIs failed with this: |
be83d8b to
3422a1b
Compare
|
@RX14 yay, the issue with Unix socket path limitation with MacOS's temp dir is back: https://circleci.com/gh/crystal-lang/crystal/12013?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
f1fef04 to
3331d34
Compare
3331d34 to
bb45203
Compare
RX14
approved these changes
Sep 12, 2018
asterite
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the large monolithic
socket_spec.crinto separate files for the individual components. This makes it easier to follow the specific component specs in their own context and improves overall readability by segregating individual features.This is the first in a series of PR's to improve the Socket API.