Revert "allow rand from zero value" #6686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6202e37. That commit introduced a bad change: it silenced a valid error for an arbitrary case. `rand(n)` is always equivalent to `rand(0...n)`. `rand(0...0)` even now says "Invalid range for rand: 0...0". `rand(0)` asks for a number >= 0 and < 0. This makes no sense and should obviously be an error for the same reason.
|
but why rand(0..0) is ok? |
|
It's "pick a number ≥ 0 and ≤ 0". That's 0. |
straight-shoota
approved these changes
Sep 9, 2018
RX14
approved these changes
Sep 9, 2018
ysbaddaden
approved these changes
Sep 9, 2018
oprypin
added a commit
to oprypin/crystal
that referenced
this pull request
Sep 9, 2018
asterite
approved these changes
Sep 10, 2018
RX14
pushed a commit
that referenced
this pull request
Sep 10, 2018
ezrast
pushed a commit
to ezrast/crystal
that referenced
this pull request
Oct 2, 2018
* Implement Random for BigInt Fixes crystal-lang#5647 * spec typo fix * Move to big_int.cr * Use to_s in spec * Remove special case of zero because it will be removed in crystal-lang#6686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #3493.
That commit introduced a bad change: it silenced a valid error for an arbitrary case.
Saying "this is useful" while showing wrong code is not an argument; that code should have just used an inclusive range.
rand(n)is always equivalent torand(0...n).rand(0...0)even now says "Invalid range for rand: 0...0".rand(0)asks for a number ≥ 0 and < 0. This makes no sense and should obviously be an error for the same reason.