Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ASTNode#to_s for {% verbatim do %} ... {% end %} #6665

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Fix ASTNode#to_s for {% verbatim do %} ... {% end %} #6665

merged 2 commits into from
Sep 12, 2018

Conversation

makenowjust
Copy link
Contributor

For example, it shows wrong result.

Code:

p!({% verbatim do %}1{{2}}3{% end %})

Result:

{% verbatim do %}1
{{ 2 }}
3
{% end %} # => 3

This PR fixes it.

@makenowjust
Fix ASTNode#to_s for {% verbatim do %} ... {% end %}
526f688 
For example, it shows wrong result.

Code:

    p!({% verbatim do %}1{{2}}3{% end %})

Result:

    {% verbatim do %}1
    {{ 2 }}
    3
    {% end %} # => 3

This commit fixes it.
@makenowjust makenowjust force-pushed the fix/crystal/to-s-verbatim branch from 90b88a9 to 526f688 Compare September 5, 2018 07:01
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler topic:stdlib:macros labels Sep 6, 2018
@makenowjust
Copy link
Contributor Author

ping. Could anyone review it?

@RX14 RX14 added this to the 0.27.0 milestone Sep 12, 2018
@RX14 RX14 merged commit e3e53b0 into crystal-lang:master Sep 12, 2018
@makenowjust makenowjust deleted the fix/crystal/to-s-verbatim branch September 12, 2018 14:04
ezrast pushed a commit to ezrast/crystal that referenced this pull request Oct 2, 2018
@makenowjust
Fix ASTNode#to_s for {% verbatim do %} ... {% end %} (crystal-lan…
d806ff8 
…g#6665)

For example, it shows wrong result.

Code:

    p!({% verbatim do %}1{{2}}3{% end %})

Result:

    {% verbatim do %}1
    {{ 2 }}
    3
    {% end %} # => 3

This commit fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@asterite asterite asterite approved these changes

@jhass jhass jhass approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler topic:stdlib:macros
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
4 participants
@makenowjust @jhass @asterite @RX14