Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make String::Builder#chomp! returns self #6583

Merged
merged 1 commit into from
Aug 28, 2018
Merged

Make String::Builder#chomp! returns self #6583

merged 1 commit into from
Aug 28, 2018

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Aug 21, 2018

Fixes #6582

sdogruyol
sdogruyol approved these changes Aug 28, 2018
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Sija 👍

@sdogruyol sdogruyol merged commit 6d88f42 into crystal-lang:master Aug 28, 2018
@sdogruyol sdogruyol added this to the 0.27.0 milestone Aug 28, 2018
ezrast pushed a commit to ezrast/crystal that referenced this pull request Oct 2, 2018
@Sija
Make String::Builder#chomp! returns self (crystal-lang#6583)
f523473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Sija @sdogruyol @RX14