Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec: fix DotFormatter to flush after every spec #6562

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Spec: fix DotFormatter to flush after every spec #6562

merged 1 commit into from
Aug 20, 2018

Conversation

asterite
Copy link
Member

Fixes #6561

@asterite
Copy link
Member Author

Please include this for 0.26.1

@bcardiff bcardiff added this to the 0.26.1 milestone Aug 18, 2018
bcardiff
bcardiff approved these changes Aug 18, 2018
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other puts that are not flushing but it’s ok to flush only here probably.

@asterite
Copy link
Member Author

@bcardiff I think it's fine, because for the other formatter (VerboseFormatter) there's @io.puts, but that @io is usually STDOUT, which has flush_on_newline = true, so it's working fine (maybe a bit convoluted, though).

sdogruyol
sdogruyol approved these changes Aug 18, 2018
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asterite 👍

@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib topic:stdlib:specs labels Aug 20, 2018
@RX14 RX14 merged commit 6c5e7a9 into crystal-lang:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:specs topic:stdlib
Projects
None yet
Milestone
0.26.1
Development

Successfully merging this pull request may close these issues.
5 participants
@asterite @bcardiff @straight-shoota @sdogruyol @RX14