Fix: use Crystal::System::Random in Crystal::Hasher

[ysbaddaden]

Using Random::Secure in prelude.cr causes some load order issues when the crystal-random shard is required, and this prevents a program compilation (e.g. the crystal-random specs). The exact issue is unknown. Maybe it's related to adding more implementations of the Random module, required by Random::Secure, and creating a kind of loop between Hash -> Crystal::Hasher -> Random::Secure <-> Random that the compiler can't satisfy.

Using Crystal::System::Random directly instead of Random::Secure (which merely delegates to Crystal::System::Random) fixes the compilation issue. I'm not fond of that solution (or hack), but it works.

[RX14]

Can you paste the error you got with the load order?

[straight-shoota]

Perhaps add a comment about using Crystal::System::Random in the code? Could be a FIXME.

[ysbaddaden]

@RX14 : just clone crystal-random, fix the require "secure_random" statements, then:

$ crystal spec --verbose
Error in line 1: while requiring "prelude"
in /usr/share/crystal/src/prelude.cr:41: while requiring "hash"
require "hash"
^
in /usr/share/crystal/src/hash.cr:1: while requiring "crystal/hasher"
require "crystal/hasher"
^
in /usr/share/crystal/src/crystal/hasher.cr:85: undefined constant Random::Secure
  Random::Secure.random_bytes(Slice.new(pointerof(@@seed).as(UInt8*), sizeof(typeof(@@seed))))
  ^~~~~~~~~~~~~~

@straight-shoota we're inside the private Crystal namespace, so it's allowed to use Crystal::System.

[ysbaddaden]

Also, a git blame would better answer the question of using Crystal::System::Random rather than Random::Secure.

[straight-shoota]

we're inside the private Crystal namespace

Ah, I missed that, sorry. It's fine then.