-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use qualified type Crystal::Path in compiler specs #6071
Use qualified type Crystal::Path in compiler specs #6071
Conversation
Looks good to me. Another idea might be to rename the What other name could we use? A |
250ad7f
to
0410ba5
Compare
you could call it a |
|
I like @straight-shoota If you want you can tweak this PR to rename |
@asterite can't a |
@RX14 That's correct. But a constant is represented internally as a type too 😛 |
OK, sounds fine to me then |
I think this is fine as it is 👍 @straight-shoota can you rebase? |
0410ba5
to
286090c
Compare
Rebased |
needs a format |
This PR adds qualified type
Crystal::Path
in compiler specs to avoid naming conflicts with top levelPath
type. It is a prerequisite for #5635 and extracted from there to reduce noise from these many whitespace changes.