Add guard clause to Deque#rotate! #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhass
approved these changes
Dec 18, 2017
|
|
|
<= 1 is probably better. |
|
If you were checking for being empty, I think |
Rotating an empty list or a list of one does not change the list, so we return early in those cases. This also fixes a DivisionByZeroError when @SiZe == 0.
9985d87 to
fb8caae
Compare
|
Thanks for the feedback everyone! I went with the |
straight-shoota
approved these changes
Dec 18, 2017
|
Welcome and congratulations for your first PR @willcosgrove 🎉 |
RX14
approved these changes
Dec 18, 2017
asterite
approved these changes
Jan 2, 2018
lukeasrodgers
pushed a commit
to lukeasrodgers/crystal
that referenced
this pull request
Jan 7, 2018
Rotating an empty list or a list of one does not change the list, so we return early in those cases. This also fixes a DivisionByZeroError when @SiZe == 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time contributing to Crystal, so please let me know if there's something I should change. I went back and forth on writing the guard clause as
@size == 0orempty?.shiftandpopused@size == 0.halfsusedempty?.On one hand, the error this is fixing is due to
@sizebeing zero. But on the other hand, it makes the most intuitive sense to me that we're short circuiting the rotation when the Deque is empty, because an empty Deque (or Array or whatever) rotated is still an empty Deque.Come to think of it, we can actually return early if
@size <= 1because a Deque of size 1 rotated any amount is still the same value.Would you like me to change this guard clause to
@size <= 1, leave it as is, or change it to@size == 0?Fixes #5393