Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SimpleHash #3562

Merged
merged 1 commit into from
Nov 20, 2016
Merged

Remove SimpleHash #3562

merged 1 commit into from
Nov 20, 2016

Conversation

sdogruyol
Copy link
Member

This fixes #2331.

As @asterite already mentioned it leads to confusion and there's no use case for this since the performance difference is negligible.

@Sija
Copy link
Contributor

Sija commented Nov 20, 2016

There's stray require left in src/docs_main.cr.

@sdogruyol
Copy link
Member Author

Fixed. Thanks @Sija

@asterite
Copy link
Member

@sdogruyol Good idea! Yes, SimpleHash doesn't have a clear use case, Hash is usually faster. Thank you!

@asterite asterite merged commit 58c85c0 into crystal-lang:master Nov 20, 2016
@sdogruyol
Copy link
Member Author

Thank you ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop SimpleHash (Was: SimpleHash and other hashes)
3 participants
@sdogruyol @Sija @asterite