Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hash#has_value? #3138

Merged
merged 2 commits into from
Aug 12, 2016
Merged

Add Hash#has_value? #3138

merged 2 commits into from
Aug 12, 2016

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Aug 11, 2016

@Sija
Copy link
Contributor

Sija commented Aug 11, 2016

@ruza-net hmm, it ain't GitHub flavored Markdown version, it's being parsed by Crystal doc generator which doesn't support it, I think... I misunderstood your comment, my bad!

@MaloJaffre
Copy link
Contributor

@ruza-net, it isn't the same thing: your version compares only the first value.

@ruza-net
Copy link

@MaloJaffre I don't understand you properly.

@ruza-net
Copy link

Oh I see, the stmt gets executed only if the expression is true, mine return bool immediately. My bad I was programming in Python a Long time :)

@kachick
Copy link
Contributor Author

kachick commented Aug 11, 2016

Thank you all! Make sure the pattern in 3e80dbc.

@asterite
Copy link
Member

@kachick Thank you!

@asterite asterite merged commit d08b492 into crystal-lang:master Aug 12, 2016
@asterite asterite added this to the 0.19.0 milestone Aug 12, 2016
@kachick
Copy link
Contributor Author

kachick commented Aug 14, 2016

Thanks to merge! :)

@kachick kachick deleted the hash-has_value branch August 14, 2016 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants