Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Filter runs of OpenSSL Test workflow #15459

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

straight-shoota
Copy link
Member

This workflow now only triggers on changes to paths that are directly related to OpenSSL.
It also runs on a nightly schedule and can be triggered manually.

Part of #14983

This workflow now only triggers on changes to paths that are directly
related to OpenSSL.
It also runs on a nightly schedule and can be triggered manually.
- 'spec/std/openssl/**'
- '.github/workflows/openssl.yml'
schedule:
- cron: '0 3 * * *'
Copy link
Contributor

@Sija Sija Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be a good idea to set the schedule to a bit different time for each of the workflows to avoid CI congestion and potentially speed up the runs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have had this discussion before. But I don't recall where.

Congestion isn't that bad. These workflows are now running only once per day, not on every commit (often even twice per).

Speed up isn't really relevant here. We just want them to run at some point in a regular interval. Doesn't matter much when exactly.

In fact, I'm considering to introduce a central orchestration workflow which runs on a schedule and calls the other ones (mentioned in #14983 (comment)). At that point all workflows would be triggered at the same time anyway.

@straight-shoota straight-shoota added this to the 1.16.0 milestone Feb 12, 2025
@straight-shoota straight-shoota merged commit ca64539 into master Feb 13, 2025
115 of 116 checks passed
@straight-shoota straight-shoota deleted the infra/ci-openssl branch February 13, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants