Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/1.15@1.15.1 #15414

Merged
merged 11 commits into from
Feb 6, 2025
Merged

Merge release/1.15@1.15.1 #15414

merged 11 commits into from
Feb 6, 2025

Conversation

straight-shoota
Copy link
Member

No description provided.

straight-shoota and others added 11 commits January 17, 2025 10:07

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
Co-authored-by: Julien Portalier <julien@portalier.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
The abstract method refers to the non existing `Index` type. Weirdly the compiler won't complain until someone defines an `Index` type.

Resolves #15357

(cherry picked from commit 5a245d9)

Co-authored-by: Johannes Müller <straightshoota@gmail.com>

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
(cherry picked from commit 2b544f1)

Co-authored-by: Billy.Zheng <vil963@gmail.com>

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
The gc_none interface doesn't define the `sig_suspend` nor `sig_resume` class methods. The program should still compile but commit 57017f6 improperly checks for the method existence, and the methods are always required and compilation fails.

(cherry picked from commit 0fbdcc9)

Co-authored-by: Julien Portalier <julien@portalier.com>

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
(cherry picked from commit 659cf25)

Co-authored-by: Johannes Müller <straightshoota@gmail.com>

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
(cherry picked from commit 2697a0f)

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@1ee31a4

This includes the following changes:

* crystal-lang/distribution-scripts#350

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
This is to detect issues like crystal-lang/distribution-scripts#330 directly in the build process.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
With `directory_listing: false` the handler returns 404 Not Found when requesting a directory with the trailing slash (`/foo/`). But, if the trailing slash is missing (`/foo`), it redirects to `/foo/` with a 302 Found response. This leaks information about the existence of directories and can lead to redirect loops if a reverse proxy tries to remove trailing slashes.

Co-authored-by: Julien Portalier <julien@portalier.com>

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
Adds support for the automated backport workflow added in #15372.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
@ysbaddaden
Copy link
Contributor

There are conflicts to solve.

@straight-shoota
Copy link
Member Author

straight-shoota commented Feb 6, 2025

Yeah but we want to merge this with a merge commit to join the two histories in git. And I don't think it's possible to resolve the conflicts ahead of time without altering the base branch (and we don't want to merge master into release/1.15). So we need to fix them in the merge commit.

I suppose an alternative would be to split a merge branch off master, merge release/1.15 into that (resolving the conflicts at that time) and then make a PR for the merge branch which would be a fast-forward from master. 🤔 => #15422

@straight-shoota straight-shoota merged commit 89aa014 into master Feb 6, 2025
140 checks passed
straight-shoota added a commit to crystal-lang/distribution-scripts that referenced this pull request Mar 13, 2025

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marandaneto Manoel Aranda Neto
@straight-shoota straight-shoota added this to the 1.16.0 milestone Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants