Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LLVM version detection for -rc1 #15410

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

HertzDevil
Copy link
Contributor

The new LLVM 20.1.0-rc1 release's llvm-config is a proper semantic version that has a hyphen before the rc1 part, and needs to be stripped.

@HertzDevil HertzDevil added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:llvm labels Feb 4, 2025
@straight-shoota straight-shoota added this to the 1.16.0 milestone Feb 4, 2025
@straight-shoota straight-shoota merged commit 1fafbb2 into crystal-lang:master Feb 5, 2025
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:llvm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants