Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework initialization of constants & class variables #15333

Merged
merged 12 commits into from
Jan 20, 2025
Merged

Rework initialization of constants & class variables #15333

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b55fc14
Improve `__crystal_once` performance
ysbaddaden Jan 6, 2025
55228fd
LLVM optimization
ysbaddaden Jan 9, 2025
9c1da89
LLVM optimization: reduce complexity at call site
ysbaddaden Jan 9, 2025
6ebfcf4
Fix: macro 'class_property' must be defined
ysbaddaden Jan 9, 2025
71a1c4d
Fix: only enabled for 1.16.0-dev (not 1.15.0-dev)
ysbaddaden Jan 10, 2025
2296069
Add LLVM optimization to legacy __crystal_once
ysbaddaden Jan 13, 2025
2c1c20b
Fix: LLVM 14 and below need explicit pointer cast (i8* -> i1*)
ysbaddaden Jan 14, 2025
273978b
Fix: missing :nodoc:
ysbaddaden Jan 14, 2025
e7527d3
Extract Intrinsics.unreachable
ysbaddaden Jan 16, 2025
e42a575
Only cast i8* to i1* on LLVM < 15
ysbaddaden Jan 16, 2025
4f5092e
No need for `Crystal.once_mutex` getter
ysbaddaden Jan 16, 2025
cf58312
Fix: crystal tool format
ysbaddaden Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/crystal/once.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,13 @@

{% if flag?(:preview_mt) || flag?(:win32) %}
@@once_mutex = uninitialized Mutex
ysbaddaden marked this conversation as resolved.
Show resolved Hide resolved
class_property once_mutex : Mutex

def self.once_mutex : Mutex
@@once_mutex
end

def self.once_mutex=(@@once_mutex : Mutex)
end
ysbaddaden marked this conversation as resolved.
Show resolved Hide resolved
{% end %}

# Using @[NoInline] so LLVM optimizes for the hot path (var already
Expand Down