Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify behavior of strict for String-to-number conversions #15199

Merged

Conversation

HertzDevil
Copy link
Contributor

@HertzDevil HertzDevil commented Nov 15, 2024

In table form:

whitespace: false whitespace: true
strict: false 1.2 1.2 1.2@@ 1.2 1.2 1.2@@
1.2 1.2 1.2@@
strict: true 1.2 1.2 1.2
1.2 1.2

The current wording suggests that the two arguments are mutually exclusive and cannot be both set to true, but the lower-right quadrant suggests otherwise. (Note that both whitespace and strict are also true by default.) This PR reflects the current status.

@straight-shoota straight-shoota added this to the 1.15.0 milestone Nov 15, 2024
@straight-shoota straight-shoota merged commit 69d192a into crystal-lang:master Nov 16, 2024
68 of 69 checks passed
@HertzDevil HertzDevil deleted the docs/string-to-number-strict branch November 18, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants