Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UNIXSocket#receive #15107

Merged

Conversation

straight-shoota
Copy link
Member

UNIXSocket#receive has been broken since at least #14384 and wouldn't even compile. We were missing specs for this entirely.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:networking labels Oct 21, 2024
@straight-shoota straight-shoota self-assigned this Oct 21, 2024
@straight-shoota straight-shoota added this to the 1.15.0 milestone Oct 21, 2024
@HertzDevil HertzDevil added the kind:regression Something that used to correctly work but no longer works label Oct 21, 2024
@straight-shoota straight-shoota merged commit 6b390b0 into crystal-lang:master Oct 22, 2024
66 checks passed
@straight-shoota straight-shoota deleted the fix/unix_socket.receive branch October 22, 2024 11:18
CTC97 pushed a commit to CTC97/crystal that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:regression Something that used to correctly work but no longer works topic:stdlib:networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants