Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove relative path to vendored shards markd and reply #13992

Conversation

nobodywasishere
Copy link
Contributor

@nobodywasishere nobodywasishere commented Nov 17, 2023

Following discussion in #13784, this PR (re)removes the relative paths to the vendored shards, allowing the Crystal compiler itself to be used as a library a lot easier.

This change does mean that in order to use the compiler within Crystal, it's necessary to add equivalent markd and reply shards to the project, as it won't be using the ones provided by the compiler itself.

Resolves #13784

@straight-shoota
Copy link
Member

This change does mean that in order to use the compiler within Crystal, it's necessary to add equivalent markd and reply shards to the project, as it won't be using the ones provided by the compiler itself.

This is not entirely correct. If you're in the root directory of the crystal repo, the libraries are available in lib which is implictly available. When you're referencing the compiler source bundled with the Crystal package, this lib folder typically wouldn't be available anyway.
So this change doesn't have much impact in breaking setups that did work befor.

@straight-shoota straight-shoota added this to the 1.11.0 milestone Nov 23, 2023
@straight-shoota straight-shoota merged commit f3b47fb into crystal-lang:master Nov 24, 2023
@nobodywasishere nobodywasishere deleted the nobody/revert-relative-require branch November 24, 2023 15:52
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move vendored shards to "src/compiler/vendor/"
4 participants