Require space, semicolon, or newline after class/module/etc. header #13375
+105
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This probably won't have a huge impact on performance but it helps make the intent here clearer.
There was a problem hiding this comment.
Have you considered extracting skip_space out of parse_path/parse_generic? Most calls to these methods are already followed by an explicit call to skip_space. So maybe we could do this everywhere and reduce some complexity?
This is just an idea. I haven't actually tried it and maybe it won't work well. It's not a requirement for merging.
# Conflicts: # spec/compiler/parser/parser_spec.cr
straight-shoota
approved these changes
May 3, 2023
Sija
reviewed
May 4, 2023
straight-shoota
approved these changes
May 4, 2023
|
We should add specs with the expected valid cases in order to not run again with the same issue that forced the reverting of #11209. |
straight-shoota
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally included in #11854
Closes #11209
Unrelated, a lot of tests in
describe "end locations" do ... enddon't have anything to do with, well, end locations.