Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IniFile should be called INIFile #2450

Closed
EvanHahn opened this issue Apr 14, 2016 · 1 comment
Closed

IniFile should be called INIFile #2450

EvanHahn opened this issue Apr 14, 2016 · 1 comment
Labels
status:accepted topic:stdlib

Comments

@EvanHahn
Copy link
Contributor

Per the coding style document:

In class names, acronyms are all-uppercase. For example, HTTP, and LibXML.

By that logic, should IniFile be renamed to INIFile?

If so, I'm happy to submit a pull request.
@ozra
Copy link
Contributor

ozra commented Apr 14, 2016

This is not the right place for me to begin a discussion on it: but I think it would be more readable to have all acronyms simply PascalCased. Everyone knows what Http, Xml, Ini stands for, they're so common they've basically become words - code would be much more readable imo, which is the priority in programming. AstNode vs ASTNode, etc.

See issue #2453 regarding it instead, keeping discussions on point. Sorry about the noise

@ozra ozra mentioned this issue Apr 14, 2016
Closed
jhass added a commit to jhass/crystal that referenced this issue May 28, 2016
@jhass
rename IniFile to INIFILE, closes crystal-lang#2450, ref crystal-lang…
c707192 
…#279
jhass added a commit to jhass/crystal that referenced this issue May 28, 2016
@jhass
Rename IniFile to INI, closes crystal-lang#2450, ref crystal-lang#279
3f0aa34
jhass added a commit to jhass/crystal that referenced this issue May 28, 2016
@jhass
Rename IniFile to INI, closes crystal-lang#2450, ref crystal-lang#279
be40b6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:accepted topic:stdlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jhass @ozra @EvanHahn