-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.12.0 #775
Release 1.12.0 #775
Conversation
✅ Deploy Preview for crystal-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some fixes.
Overall I think it's too detailed and people might get bored and miss the important bits. I rather remove bugfixes/improvements without much impact on the final user. This is a proposed list of things to remove:
- Init schedulers before we spawn fibers (#14339).
- Use per-scheduler stack pools (let’s recycle) (#14100).
- Reserve stack space on non-main threads for crash recovery on Windows (#14187).
(Maybe move it to the Windows section?) - Make equality between Complex and other numbers exact (#14309).
- Fix #hash for the Big* number types (#14308).
- Handle invalid parameter error in MSVC calls to prevent an immediate process exit (#14313)
- Crystal::System::FileDescriptor::Handle is a generic alias to the platform-specific type representing a file descriptor (#14390)
- Hash#update (#14417) and Hash#put_if_absent (#14427) no longer put duplicate keys if the block inserts the key.
- FileUtils.mv works across filesystems on Windows (#14320).
(Maybe move to Windows section?)
And I'd just mention the several fixes in the formatter without being explicit.
Co-authored-by: Beta Ziliani <beta@manas.tech>
I dropped some of the less relevant bug fixes. But many that you mentioned are part of the current projects Concurrency/MT and Windows. I think it makes sense to mention a bit more details what's going on there. |
No description provided.