Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.12.0 #775

Merged
merged 9 commits into from
Apr 9, 2024
Merged

Release 1.12.0 #775

merged 9 commits into from
Apr 9, 2024

Conversation

straight-shoota
Copy link
Member

No description provided.

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for crystal-website ready!

Name Link
🔨 Latest commit c7e3e57
🔍 Latest deploy log https://app.netlify.com/sites/crystal-website/deploys/66154c87d29dd20008f6b869
😎 Deploy Preview https://deploy-preview-775--crystal-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some fixes.

Overall I think it's too detailed and people might get bored and miss the important bits. I rather remove bugfixes/improvements without much impact on the final user. This is a proposed list of things to remove:

  • Init schedulers before we spawn fibers (#14339).
  • Use per-scheduler stack pools (let’s recycle) (#14100).
  • Reserve stack space on non-main threads for crash recovery on Windows (#14187).
    (Maybe move it to the Windows section?)
  • Make equality between Complex and other numbers exact (#14309).
  • Fix #hash for the Big* number types (#14308).
  • Handle invalid parameter error in MSVC calls to prevent an immediate process exit (#14313)
  • Crystal::System::FileDescriptor::Handle is a generic alias to the platform-specific type representing a file descriptor (#14390)
  • Hash#update (#14417) and Hash#put_if_absent (#14427) no longer put duplicate keys if the block inserts the key.
  • FileUtils.mv works across filesystems on Windows (#14320).
    (Maybe move to Windows section?)

And I'd just mention the several fixes in the formatter without being explicit.

@straight-shoota
Copy link
Member Author

I dropped some of the less relevant bug fixes. But many that you mentioned are part of the current projects Concurrency/MT and Windows. I think it makes sense to mention a bit more details what's going on there.

@straight-shoota straight-shoota marked this pull request as ready for review April 9, 2024 13:14
@straight-shoota straight-shoota merged commit 0d472da into master Apr 9, 2024
6 checks passed
@straight-shoota straight-shoota deleted the release/1.12.0 branch April 9, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants