Update platform support #678
Conversation
✅ Deploy Preview for crystal-book ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
|
||
| | Target | Description | Supported versions | | ||
| | ------ | ----------- | ------------------ | | ||
| | `x86_64-darwin` | x64 macOS (Intel) | 11+<br> *(testing only on 11; expected to work on 10.7+)* | |
There was a problem hiding this comment.
Maybe we can add a Comment column and move "expected to work on 10.7+" there, and remove the "testing only..." part?
There was a problem hiding this comment.
And perhaps we could be consistent with the rest of the tables and add a ✅ build ✅ tests ✅ binaries (see below)
There was a problem hiding this comment.
I think it's relevant to mention which version we're actually testing on. We're currently not testing macOS 12 (crystal-lang/crystal#12570), so liability of this OS version is similar as for aarch64-darwin which is Tier 2.
Sure, we can add a Comment column here as well with the individual aspects. I just thought we can skip that because for Tier 1 everything needs to be ticked. Maybe it's more consistent that way...
| * ❌ means automated tests or builds are not available | ||
| * ✅ means automated tests or builds are available | ||
| * 🟡 means automated test are available, but the implementation is incomplete |
There was a problem hiding this comment.
Two stylistic suggestions: b/w icons and avoid the red cross as it suggests tests are failing, which is a stronger statement.
| * ❌ means automated tests or builds are not available | |
| * ✅ means automated tests or builds are available | |
| * 🟡 means automated test are available, but the implementation is incomplete | |
| * ◻︎ means automated tests or builds are not available | |
| * ☑︎ means automated tests or builds are available | |
| * ● means automated test are available, but the implementation is incomplete |
There was a problem hiding this comment.
PS I don't know how these icons look in the page (but I know I don't like the current ones)
There was a problem hiding this comment.
IMO the visuals fit very nicely with the rest of the page. Your suggested icons do not. I'll see if I can find some alternative suggestions.
There was a problem hiding this comment.
Btw. we're not limited to Unicode: https://squidfunk.github.io/mkdocs-material/reference/icons-emojis
There was a problem hiding this comment.
the visuals fit very nicely with the rest of the page.
Not critical, but I disagree: the 3d looking icons do not match anything on that flat-looking page. Anyway, the most critical aspect to me is avoiding the red cross.
There was a problem hiding this comment.
Here are some suggestions for icon combinations:
There was a problem hiding this comment.
I prefer coloured indicators for easy readability. I like the Unicode icons best for this, but unfortunately, the visuals are platform-specific and thus inconsistent. I could not recreate a decent coloured set with mkdocs icons (Temoji), they're inconsistent (the red circle is too big, the others are sitting too low).
Of these other alternatives, I think Material circles and Material checkbox circles are looking best.
Another option would be to use coloured icons via different means (for example directly embedded images or SVGs). This would make the source a bit nasty but IMO has the best results.
There was a problem hiding this comment.
For reference, this is what I see (c'mon Apple!)
There was a problem hiding this comment.
I like the Material Circle. I think it gives a quick visual clue: empty, half, full, easy peasy
There was a problem hiding this comment.
Yeah, it looked good but didn't work out well in practice. In the tables it looked too much like checkboxes and was asking to be clicked 😆
So I came up with a small modification, and I'm quite happy with it. The empty circle has a dashed line to symbolize absence and the full circle has a check mark in it to symbolize success. Also I changed the fill ratio of the partial circle to 5/8 which looks more pleasant than a clean 4/8.
Co-authored-by: Beta Ziliani <beta@manas.tech>
There was a problem hiding this comment.
This is perfect, thanks @straight-shoota for your attention to details! Let's make a new PR promoting musl to Tier 1 🚀
Enhance information about minimum supported versions and limitations of lower-tier platforms.
Resolves crystal-lang/crystal#13170