Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove double return workarounds. #750

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

maximebuyse
Copy link
Contributor

cryspen/hax#720 is now fixed in hax main (by cryspen/hax#1223) so we can remove the corresponding workarounds.

@maximebuyse maximebuyse requested a review from a team as a code owner January 15, 2025 09:01
@maximebuyse maximebuyse force-pushed the remove-double-return-workarounds branch from b8f9140 to e738dd9 Compare January 15, 2025 09:04
@maximebuyse maximebuyse force-pushed the remove-double-return-workarounds branch from e738dd9 to 8619341 Compare January 15, 2025 09:16
@maximebuyse
Copy link
Contributor Author

Let's wait for #748 to be merged to check if CI passes.

@franziskuskiefer
Copy link
Member

@maximebuyse I suspect that the F* output changed with this? Did you re-generate F* (./hax.py extract)?
Otherwise I'm happy with this when the CI is happy with it.
Very happy to get rid of those workaround 🙂

@maximebuyse
Copy link
Contributor Author

@maximebuyse I suspect that the F* output changed with this? Did you re-generate F* (./hax.py extract)? Otherwise I'm happy with this when the CI is happy with it. Very happy to get rid of those workaround 🙂

Right, I re-generated for ml-dsa and ml-kem now.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@franziskuskiefer franziskuskiefer merged commit 4f470c8 into main Jan 15, 2025
57 checks passed
@franziskuskiefer franziskuskiefer deleted the remove-double-return-workarounds branch January 15, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants