Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned unlock success #245

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Conversation

overheadhunter
Copy link
Member

Replaced the green "welcome back, alice" screens with more useful messages and matching the design of the remaining page.

Also added a new state when unlocking a vault after migrating to 1.3.0, when the account requires setting up user keys.

Note

Not yet localized, as we require to guess the browser language, first.

when oauth failed

Bildschirmfoto 2023-11-24 um 13 38 46

when user didn't complete setup yet

Bildschirmfoto 2023-11-24 um 13 38 56

when the app needs registration

either on a known browser:
Bildschirmfoto 2023-11-24 um 13 37 53

or when the browser is unknown:
Bildschirmfoto 2023-11-24 um 13 37 56

403

Bildschirmfoto 2023-11-24 um 13 41 08

success

Bildschirmfoto 2023-11-24 um 13 40 09

* Only assign the state to a variable if the browser keys exist.
* Use AccountState whenever possible
* If unlocking is successful, tell the user to return to Cryptomator
Copy link
Member

@SailReal SailReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just one thing I noticed and wanted to mention, but I'm totally fine with, is that with a successful legacy device unlock, the "when user didn't complete setup yet" variant is shown, but this is perfectly fine imo, because even if the user has set up their user keys, they can still use the legacy unlock.

@infeo
Copy link
Member

infeo commented Nov 24, 2023

I suggest to change the wording of the "Setup Required" screen, the "few simple steps" sounds very vague and not reassuring. I plead for keeping it simple:

To unlock, you need to setup your account.

And then also update the button description, because "Complete setup" sounds like the user already started:

Setup Account

@overheadhunter
Copy link
Member Author

I suggest to change the wording of the "Setup Required" screen, the "few simple steps" sounds very vague and not reassuring. I plead for keeping it simple:

To unlock, you need to setup your account.

Actually, legacy unlock may work, as Julian mentioned above. Nevertheless users shall complete setting up the account keys.

But I'll get rid of the "few simple steps", it really is just a single step anyway.

And then also update the button description, because "Complete setup" sounds like the user already started:

Setup Account

This also affects users who already have an account, thus it would sound as if their account was deleted. Thus I'll keep the "Complete" metaphor to not slow this PR down, but am open for other suggestions.

@tobihagemann tobihagemann added this to the 1.3.0 milestone Nov 24, 2023
@overheadhunter overheadhunter merged commit bb7b860 into release/1.3.0 Nov 24, 2023
@overheadhunter overheadhunter deleted the redesigned-unlock-success branch November 24, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants