-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Api framework #1232
Merged
Merged
Feature: Api framework #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included 3 API end points: ###/api/specter ["GET"] Basic Specter info from app.specter class ###/api/full_txlist/ ["GET"] Full Transaction list for all wallets ###"/api/wallet_info/<wallet_alias>/ ["GET"] More detailed wallet info and transactions from the app.specter.wallet_manager class
Include `wallet.check_unused()` Co-authored-by: benk10 <ben.kaufman10@gmail.com>
Made a few changes: - Flattened the wallet list to be similar to full transaction list - included versioning on url `/v1alpha/` - Included `wallet.utxo` data - Improved `safe_serialize` for better json output Pending Updates: - Create a separate file for API (as a blueprint) - Explore using Flask-restful for improved authentication (downside is that it is another dependency - not sure if already a requirement for specter)
implementing Flask-Restful
Closed
ben-kaufman
reviewed
Jun 30, 2021
ben-kaufman
reviewed
Jun 30, 2021
ben-kaufman
reviewed
Jun 30, 2021
ben-kaufman
reviewed
Jun 30, 2021
ben-kaufman
reviewed
Jul 8, 2021
Co-authored-by: benk10 <ben.kaufman10@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the PR #713 but moving the code to a non-master branch on my remote.
Will close the original PR. With this PR, Specter gets an API. The documentation is in the docs-folder.
The API is only activated if:
It's also active by default in Dev-Mode.
Apart from this new feature:
bitcoin_regtest
fixture changed scope frommodule
tosession
. This means that the regtest-node is only be spun up exactly once for the tests.cryptography
) needed a newer OS-version but the used cypress-image was based on an old debian-image. So i've created a new base-imagedocker/cypress-base-ubuntu-focal/Dockerfile
which is ubuntu based and what is from now on the new base fordocker/cypress-python/Dockerfile
user.password
is now a property which will automatically detect a plain-password and will do the necessary salted hashingpsbt_creator.py
very similiar to thewallet_imported.py
. There are people calling that a "command-pattern".wallet_importer.py
got some improvements as wellwallet.py
has a change where we're rather throwing an error than returning 0-balances. We should have more courage to raiseSpecterErrors
k9ert, [21.06.21 14:26]