Upgrade dependencies to dcrd v2.0.2 #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coins Mixing using the new implementation works. |
c48367b to
0efceb3
Compare
|
The failure of the Linter tool has been resolved here: #545 |
|
fix conflicts |
0efceb3 to
0a530b3
Compare
|
NOTE TO TESTERS: Testing this PR upgrades your database which can no longer be downgraded after |
I noticed that! Sorry for not sharing that information earliest possible. |
65a5696 to
faa29b3
Compare
|
I have identified the following error while testing the ticket purchase functionality: Fixing it ASAP: |
|
The confirm password modal to start mixing is stuck spinning
The disconnection/re-connection modal keeps stacking themselves, i have to "infinitely" keep clicking okay to close each of them with no end in sight
|
|
i see this error, but at no point am i asked to unlock my wallet. i get this error when i click on a ticket to open the ticket details page, the ticket details page opens, but still throws the error in the log |
8ad416e to
bbf0910
Compare
|
Confirmation that a ticket can be bought now withOUT crashing the app or creating Tickets that are UNmined: |
|
@dreacot I don't understand why your confirm spinner reference above has been stuck. I think the issue might be related to your network because all along I have experienced such a situation.
|
|
Newly bought ticket is now live: 
|
|
please resolve conflicts |
JustinBeBoy
requested changes
Jul 2, 2024
There was a problem hiding this comment.
@dreacot @dmigwi
Do we need stakeShuffle before buy ticket on staking ? If so, notice users when they buy tickets without stakeshuffle
I get this error when buy ticket
2024-07-02 10:33:40.601 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.601 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.601 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.601 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.602 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.602 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.602 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.602 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.602 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.602 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.602 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
2024-07-02 10:33:40.602 [ERR] DCR: [5] Ticket purchasing failed: Mixing and Unmixing Accounts are not set
Also I get error when click to my ticket for show detail
2024-07-02 10:31:02.391 [WRN] DCR: unable to getWallet info using ticket: cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384 Error: item does not exist: no VSP info for ticket cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384
2024-07-02 10:31:02.391 [ERR] UI: VSPTicketInfo error: item does not exist: no VSP info for ticket cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384
2024-07-02 10:31:02.391 [WRN] DCR: unable to getWallet info using ticket: cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384 Error: item does not exist: no VSP info for ticket cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384
2024-07-02 10:31:02.391 [ERR] UI: VSPTicketInfo error: item does not exist: no VSP info for ticket cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384
JoeGruffins
approved these changes
Jul 2, 2024
1b98e86 to
1de2b86
Compare
@JustinBeBoy |
dreacot
approved these changes
Jul 3, 2024
|
|
@JustinBeBoy Your two issue raised above have been addressed. Please review the code again! The warnings below should be better than the |
For locked wallet do not log error when fetching ticket info
aeb81ec to
6ab6339
Compare
JustinBeBoy
requested changes
Jul 5, 2024
There was a problem hiding this comment.
I still get this log when click on my Revoked ticket(not watch only wallet, you need your wallet have ticket):
2024-07-05 13:58:13.607 [INF] DCR: [5] Running ticket buyer
2024-07-05 13:58:40.884 [WRN] DCR: unable to getWallet info using ticket: cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384 Error: item does not exist: no VSP info for ticket cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384
2024-07-05 13:58:40.884 [ERR] UI: VSPTicketInfo error: item does not exist: no VSP info for ticket cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384
2024-07-05 13:58:40.884 [WRN] DCR: unable to getWallet info using ticket: cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384 Error: item does not exist: no VSP info for ticket cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384
2024-07-05 13:58:40.884 [ERR] UI: VSPTicketInfo error: item does not exist: no VSP info for ticket cac52a6d1c83d9688ef5f64aade9635dfb4918f4250a16969b5ad18f35a15384
Your revoked ticket above indicates that you didn't successfully purchase the said ticket. Something went wrong and your ticket wasn't mined. That ticket hash probably exists only in your local wallet instance and therefore the error when you try to view its details. |
JustinBeBoy
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #560
NOTE TO TESTERS: Testing this PR, upgrades your database which can no longer be downgraded.
This PR upgrades to
decred.org/dcrwallet/v4that depends ongithub.com/decred/dcrd v2.0.2More changes introduced as a result of the dependencies upgrade.:
ubuntu-latesttoubuntu-20.04due to CI linter error documented here: The runner has received a shutdown signal. actions/runner-images#6709 (comment)Tests Run on the code.