Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup integration test infrastructure #8

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Setup integration test infrastructure #8

merged 1 commit into from
Aug 16, 2021

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Aug 11, 2021

Closes #3

  • use nix
  • support both cronos and geth

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang
Setup integration tset infrastructure
2f4895c 
Closes #3

- use nix
- support both cronos and geth
@yihuang yihuang changed the title Setup integration tset infrastructure Setup integration test infrastructure Aug 12, 2021
@yihuang yihuang requested a review from JayT106 August 12, 2021 01:58
tomtau
tomtau approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all right, just not sure of some of the hardcoded address constants where they come from

default.nix
{ system ? builtins.currentSystem, pkgs ? import ./nix { inherit system; } }:
pkgs.buildGoApplication rec {
pname = "cronosd";
version = "0.0.0";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match the current release candidate?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

integration_tests/utils.py
from pystarport.ports import rpc_port

KEYS = {
"validator": "826E479F5385C8C32CD96B0C0ACCDB8CC4FA5CACCC1BE54C1E3AA4D676A6EFF5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be read from the yaml configs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's possible, need to derive it on the fly though, based on the mnemonic words in the config file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to fix the hardcoded stuff in another PR.
#10

nix/scripts.nix

# import validator key
cat > $tmpfile << EOF
826E479F5385C8C32CD96B0C0ACCDB8CC4FA5CACCC1BE54C1E3AA4D676A6EFF5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from Geth genesis?

Copy link
Collaborator Author

@yihuang yihuang Aug 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no private key in the geth genesis file, maybe need to derive them based on the mnemonic words from cronos config file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to fix the hardcoded stuff in another PR.
#10

This was referenced Aug 16, 2021
Closed
Closed
@yihuang
Copy link
Collaborator Author

yihuang commented Aug 16, 2021

Will run integration tests in CI in another PR.

@yihuang yihuang merged commit 91d1759 into crypto-org-chain:main Aug 16, 2021
@yihuang yihuang deleted the test-env branch August 16, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtau tomtau tomtau approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto

@thomas-nguy thomas-nguy Awaiting requested review from thomas-nguy

@JayT106 JayT106 Awaiting requested review from JayT106

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: no integration tests framework
2 participants
@yihuang @tomtau