-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: ethermint 'remove tx logs' version is not used #70
Conversation
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 21.51% 26.15% +4.64%
==========================================
Files 27 32 +5
Lines 1729 2183 +454
==========================================
+ Hits 372 571 +199
- Misses 1324 1575 +251
- Partials 33 37 +4
Continue to review full report at Codecov.
|
1e3ca2a
to
28b49f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
github.com/tendermint/tm-db v0.6.4 | ||
github.com/tharsis/ethermint v0.4.2-0.20210905110306-26c5eabb1893 | ||
google.golang.org/genproto v0.0.0-20210903162649-d08c68adba83 | ||
github.com/tharsis/ethermint v0.4.2-0.20210915094503-116de5461766 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tag should be v0.5.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's figured out by go mod tidy
automatically, not sure why it didn't pick the v0.5 tag
evmos/ethermint#556
Removed tx logs and block bloom from chain state in ethermint side, check that Cronos CI checks all passes.
Update dependency after upstream PR merged.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)