Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: didn't disable the url query parameter in swagger ui #345

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Problem: didn't disable the url query parameter in swagger ui #345

merged 2 commits into from
Feb 16, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Feb 15, 2022

Solution:

  • update to recent swagger ui version
  • add option queryConfigEnabled: false.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang
Problem: didn't disable the url query parameter in swagger ui
73fac70 
Solution:
- update to recent swagger ui version
- add option `queryConfigEnabled: false`.
@yihuang yihuang requested a review from a team as a code owner February 15, 2022 13:24
@yihuang yihuang requested review from devashishdxt, adu-crypto and tomtau and removed request for a team February 15, 2022 13:24
@yihuang yihuang added the backport/0.6.x backport to release/v0.6.x label Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022 •
edited
Loading

Codecov Report

Merging #345 (73fac70) into main (3ea70c5) will increase coverage by 19.54%.
The diff coverage is n/a.

❗ Current head 73fac70 differs from pull request most recent head 28c918c. Consider uploading reports for the commit 28c918c to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #345       +/-   ##
===========================================
+ Coverage   21.51%   41.06%   +19.54%     
===========================================
  Files          27       30        +3     
  Lines        1729     1505      -224     
===========================================
+ Hits          372      618      +246     
+ Misses       1324      841      -483     
- Partials       33       46       +13
Impacted Files Coverage Δ
x/cronos/genesis.go 61.53% <ø> (-38.47%) ⬇️
x/cronos/handler.go 100.00% <ø> (ø)
x/cronos/keeper/evm.go 58.00% <ø> (+6.27%) ⬆️
x/cronos/keeper/evm_hooks.go 80.00% <ø> (ø)
x/cronos/keeper/evm_log_handlers.go 83.50% <ø> (ø)
x/cronos/keeper/gravity_hooks.go 0.00% <ø> (ø)
x/cronos/keeper/grpc_query.go 0.00% <ø> (ø)
x/cronos/keeper/ibc.go 83.20% <ø> (+5.01%) ⬆️
x/cronos/keeper/ibc_hooks.go 50.00% <ø> (-8.83%) ⬇️
x/cronos/keeper/keeper.go 64.89% <ø> (-29.45%) ⬇️
... and 28 more

yihuang
yihuang commented Feb 15, 2022
View reviewed changes
app/app.go
@@ -855,7 +855,7 @@ func (app *App) RegisterTendermintService(clientCtx client.Context) {

// RegisterSwaggerAPI registers swagger route with API Server
func RegisterSwaggerAPI(ctx client.Context, rtr *mux.Router) {
statikFS, err := fs.New()
statikFS, err := fs.NewWithNamespace("cronos")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used a different namespace to prevent potential conflict with the one used by cosmos-sdk's simd.

thomas-nguy
thomas-nguy approved these changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add entry in changelog

@yihuang
Copy link
Collaborator Author

yihuang commented Feb 16, 2022

maybe add entry in changelog

added now.

@yihuang yihuang merged commit 6e0bebb into crypto-org-chain:main Feb 16, 2022
@yihuang yihuang deleted the update-swagger-ui branch February 16, 2022 01:45
yihuang added a commit to yihuang/cronos that referenced this pull request Feb 16, 2022
@yihuang
Problem: didn't disable the url query parameter in swagger ui (backport
02cf420 
crypto-org-chain#345)

Solution:
- update to recent swagger ui version
- add option `queryConfigEnabled: false`.
yihuang added a commit that referenced this pull request Feb 16, 2022
@yihuang
Problem: didn't disable the url query parameter in swagger ui (backport
b99f20c 
#345) (#346)

* Problem: didn't disable the url query parameter in swagger ui (backport #345)

Solution:
- update to recent swagger ui version
- add option `queryConfigEnabled: false`.

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@tomtau tomtau tomtau approved these changes

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev

@adu-crypto adu-crypto Awaiting requested review from adu-crypto adu-crypto is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
backport/0.6.x backport to release/v0.6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @tomtau @thomas-nguy