-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: ethermint v0.9.0 is not used #241
Changes from 14 commits
b3222e7
32a83ad
c781c88
34dd05b
6944c31
4cea377
9646a8a
4011dc9
9694d47
90e6ffb
a6dbe3f
3cfefc7
9b5a07e
60d3e63
26ff78c
766847a
1ab9582
49eb101
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -4,14 +4,14 @@ go 1.17 | |||||||
|
||||||||
require ( | ||||||||
github.com/armon/go-metrics v0.3.9 | ||||||||
github.com/cosmos/cosmos-sdk v0.44.3 | ||||||||
github.com/cosmos/ibc-go v1.2.2 | ||||||||
github.com/ethereum/go-ethereum v1.10.3 | ||||||||
github.com/cosmos/cosmos-sdk v0.44.5 | ||||||||
github.com/cosmos/ibc-go/v2 v2.0.0 | ||||||||
github.com/ethereum/go-ethereum v1.10.11 | ||||||||
github.com/gogo/protobuf v1.3.3 | ||||||||
github.com/golang/protobuf v1.5.2 | ||||||||
github.com/gorilla/mux v1.8.0 | ||||||||
github.com/grpc-ecosystem/grpc-gateway v1.16.0 | ||||||||
github.com/peggyjv/gravity-bridge/module v0.2.0 | ||||||||
github.com/peggyjv/gravity-bridge/module v0.2.24-0.20211206214839-d22e7091a41d | ||||||||
github.com/rakyll/statik v0.1.7 | ||||||||
github.com/spf13/cast v1.4.1 | ||||||||
github.com/spf13/cobra v1.2.1 | ||||||||
|
@@ -20,8 +20,8 @@ require ( | |||||||
github.com/tendermint/tendermint v0.34.14 | ||||||||
github.com/tendermint/tm-db v0.6.4 | ||||||||
github.com/tharsis/ethermint v0.7.2 | ||||||||
google.golang.org/genproto v0.0.0-20210909211513-a8c4777a87af | ||||||||
google.golang.org/grpc v1.41.0 | ||||||||
google.golang.org/genproto v0.0.0-20211116182654-e63d96a377c4 | ||||||||
google.golang.org/grpc v1.42.0 | ||||||||
gopkg.in/yaml.v2 v2.4.0 | ||||||||
) | ||||||||
|
||||||||
|
@@ -31,19 +31,21 @@ require ( | |||||||
github.com/ChainSafe/go-schnorrkel v0.0.0-20200405005733-88cbf1b4c40d // indirect | ||||||||
github.com/DataDog/zstd v1.4.8 // indirect | ||||||||
github.com/StackExchange/wmi v1.2.1 // indirect | ||||||||
github.com/VictoriaMetrics/fastcache v1.5.7 // indirect | ||||||||
github.com/VictoriaMetrics/fastcache v1.6.0 // indirect | ||||||||
github.com/Workiva/go-datastructures v1.0.52 // indirect | ||||||||
github.com/allegro/bigcache v1.2.1 // indirect | ||||||||
github.com/beorn7/perks v1.0.1 // indirect | ||||||||
github.com/bgentry/speakeasy v0.1.0 // indirect | ||||||||
github.com/btcsuite/btcd v0.22.0-beta // indirect | ||||||||
github.com/btcsuite/btcutil v1.0.3-0.20201208143702-a53e38424cce // indirect | ||||||||
github.com/cenkalti/backoff/v4 v4.1.1 // indirect | ||||||||
github.com/cespare/xxhash v1.1.0 // indirect | ||||||||
github.com/cespare/xxhash/v2 v2.1.1 // indirect | ||||||||
github.com/coinbase/rosetta-sdk-go v0.6.10 // indirect | ||||||||
github.com/confio/ics23/go v0.6.6 // indirect | ||||||||
github.com/cosmos/btcutil v1.0.4 // indirect | ||||||||
github.com/cosmos/go-bip39 v1.0.0 // indirect | ||||||||
github.com/cosmos/iavl v0.17.1 // indirect | ||||||||
github.com/cosmos/iavl v0.17.3 // indirect | ||||||||
github.com/cosmos/ledger-cosmos-go v0.11.1 // indirect | ||||||||
github.com/cosmos/ledger-go v0.9.2 // indirect | ||||||||
github.com/danieljoos/wincred v1.0.2 // indirect | ||||||||
|
@@ -56,7 +58,6 @@ require ( | |||||||
github.com/dustin/go-humanize v1.0.0 // indirect | ||||||||
github.com/dvsekhvalnov/jose2go v0.0.0-20200901110807-248326c1351b // indirect | ||||||||
github.com/edsrzf/mmap-go v1.0.0 // indirect | ||||||||
github.com/enigmampc/btcutil v1.0.3-0.20200723161021-e2fb6adb2a25 // indirect | ||||||||
github.com/felixge/httpsnoop v1.0.1 // indirect | ||||||||
github.com/fsnotify/fsnotify v1.5.1 // indirect | ||||||||
github.com/gballet/go-libpcsclite v0.0.0-20190607065134-2772fd86a8ff // indirect | ||||||||
|
@@ -66,7 +67,7 @@ require ( | |||||||
github.com/go-stack/stack v1.8.0 // indirect | ||||||||
github.com/godbus/dbus v0.0.0-20190726142602-4481cbc300e2 // indirect | ||||||||
github.com/gogo/gateway v1.1.0 // indirect | ||||||||
github.com/golang/snappy v0.0.3 // indirect | ||||||||
github.com/golang/snappy v0.0.4 // indirect | ||||||||
github.com/google/btree v1.0.1 // indirect | ||||||||
github.com/google/orderedcode v0.0.1 // indirect | ||||||||
github.com/google/uuid v1.3.0 // indirect | ||||||||
|
@@ -82,9 +83,9 @@ require ( | |||||||
github.com/hashicorp/hcl v1.0.0 // indirect | ||||||||
github.com/hdevalence/ed25519consensus v0.0.0-20210204194344-59a8610d2b87 // indirect | ||||||||
github.com/holiman/bloomfilter/v2 v2.0.3 // indirect | ||||||||
github.com/holiman/uint256 v1.1.1 // indirect | ||||||||
github.com/huin/goupnp v1.0.1-0.20210310174557-0ca763054c88 // indirect | ||||||||
github.com/improbable-eng/grpc-web v0.14.1 // indirect | ||||||||
github.com/holiman/uint256 v1.2.0 // indirect | ||||||||
github.com/huin/goupnp v1.0.2 // indirect | ||||||||
github.com/improbable-eng/grpc-web v0.15.0 // indirect | ||||||||
github.com/inconshreveable/mousetrap v1.0.0 // indirect | ||||||||
github.com/jackpal/go-nat-pmp v1.0.2-0.20160603034137-1fa385a6f458 // indirect | ||||||||
github.com/jmhodges/levigo v1.0.0 // indirect | ||||||||
|
@@ -101,7 +102,6 @@ require ( | |||||||
github.com/mitchellh/mapstructure v1.4.2 // indirect | ||||||||
github.com/mtibben/percent v0.2.1 // indirect | ||||||||
github.com/olekukonko/tablewriter v0.0.5 // indirect | ||||||||
github.com/palantir/stacktrace v0.0.0-20161112013806-78658fd2d177 // indirect | ||||||||
github.com/pelletier/go-toml v1.9.4 // indirect | ||||||||
github.com/petermattis/goid v0.0.0-20180202154549-b0b1615b78e5 // indirect | ||||||||
github.com/pkg/errors v0.9.1 // indirect | ||||||||
|
@@ -115,15 +115,15 @@ require ( | |||||||
github.com/regen-network/cosmos-proto v0.3.1 // indirect | ||||||||
github.com/rjeczalik/notify v0.9.1 // indirect | ||||||||
github.com/rs/cors v1.8.0 // indirect | ||||||||
github.com/rs/zerolog v1.25.0 // indirect | ||||||||
github.com/rs/zerolog v1.26.0 // indirect | ||||||||
github.com/sasha-s/go-deadlock v0.2.1-0.20190427202633-1595213edefa // indirect | ||||||||
github.com/shirou/gopsutil v3.21.4-0.20210419000835-c7a38de76ee5+incompatible // indirect | ||||||||
github.com/spf13/afero v1.6.0 // indirect | ||||||||
github.com/spf13/jwalterweatherman v1.1.0 // indirect | ||||||||
github.com/spf13/viper v1.9.0 // indirect | ||||||||
github.com/status-im/keycard-go v0.0.0-20200402102358-957c09536969 // indirect | ||||||||
github.com/subosito/gotenv v1.2.0 // indirect | ||||||||
github.com/syndtr/goleveldb v1.0.1-0.20210305035536-64b5b1c73954 // indirect | ||||||||
github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 // indirect | ||||||||
github.com/tecbot/gorocksdb v0.0.0-20191217155057-f0fad39f321c // indirect | ||||||||
github.com/tendermint/btcd v0.1.1 // indirect | ||||||||
github.com/tendermint/crypto v0.0.0-20191022145703-50d29ede1e15 // indirect | ||||||||
|
@@ -133,14 +133,13 @@ require ( | |||||||
github.com/tyler-smith/go-bip39 v1.1.0 // indirect | ||||||||
github.com/zondax/hid v0.9.0 // indirect | ||||||||
go.etcd.io/bbolt v1.3.6 // indirect | ||||||||
golang.org/x/crypto v0.0.0-20210817164053-32db794688a5 // indirect | ||||||||
golang.org/x/net v0.0.0-20210903162142-ad29c8ab022f // indirect | ||||||||
golang.org/x/crypto v0.0.0-20211115234514-b4de73f9ece8 // indirect | ||||||||
golang.org/x/net v0.0.0-20211111160137-58aab5ef257a // indirect | ||||||||
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect | ||||||||
golang.org/x/sys v0.0.0-20210903071746-97244b99971b // indirect | ||||||||
golang.org/x/sys v0.0.0-20211111213525-f221eed1c01e // indirect | ||||||||
golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1 // indirect | ||||||||
golang.org/x/text v0.3.6 // indirect | ||||||||
golang.org/x/text v0.3.7 // indirect | ||||||||
google.golang.org/protobuf v1.27.1 // indirect | ||||||||
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect | ||||||||
gopkg.in/ini.v1 v1.63.2 // indirect | ||||||||
gopkg.in/natefinch/npipe.v2 v2.0.0-20160621034901-c1b8fa8bdcce // indirect | ||||||||
gopkg.in/olebedev/go-duktape.v3 v3.0.0-20200619000410-60c24ae608a6 // indirect | ||||||||
|
@@ -156,17 +155,8 @@ replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alp | |||||||
replace github.com/99designs/keyring => github.com/crypto-org-chain/keyring v1.1.6-fixes | ||||||||
|
||||||||
// TODO: remove when middleware will be implemented | ||||||||
replace github.com/cosmos/ibc-go => github.com/crypto-org-chain/ibc-go v1.2.1-hooks | ||||||||
replace github.com/cosmos/ibc-go/v2 => github.com/crypto-org-chain/ibc-go/v2 v2.0.0-hooks-2 | ||||||||
thomas-nguy marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
|
||||||||
replace github.com/cosmos/iavl => github.com/cosmos/iavl v0.17.1 | ||||||||
replace github.com/cosmos/iavl => github.com/cosmos/iavl v0.17.2 | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. v0.17.2 had some race condition / concurrent access issues -- not sure if this can manifest in Ethermint / Web3 APIs: cosmos/iavl@v0.17.2...v0.17.3 but perhaps better to use the latest one? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. updated |
||||||||
|
||||||||
replace github.com/ethereum/go-ethereum => github.com/crypto-org-chain/go-ethereum v1.10.3-patched | ||||||||
|
||||||||
// TODO: remove when ibc-go and ethermint upgrades cosmos-sdk | ||||||||
replace github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.44.2 | ||||||||
|
||||||||
replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.7.2-cronos-4 | ||||||||
|
||||||||
// FIXME: update after PR merged: https://github.com/PeggyJV/gravity-bridge/pull/182 | ||||||||
// https://github.com/crypto-org-chain/gravity-bridge/tree/cronos | ||||||||
replace github.com/peggyjv/gravity-bridge/module => github.com/crypto-org-chain/gravity-bridge/module v0.1.22-0.20211011065300-a09cf050d304 | ||||||||
replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.6.1-0.20211207040748-254df3803d62 | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if the ibc-go module version increased? https://github.com/cosmos/ibc-go/blob/main/modules/core/module.go#L164
there isn't much change between ibc-go 1 and 2, but not sure whether one shouldn't explicitly pass it in the upgrade handler so that the version map gets upgraded for the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
fromVM
is loaded from the storage, andRunMigrations
will migrate them to current version automatically, so it should work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if that's desirable with the fork to upstream migration later (I'm assuming when it adds the hooks or middleware, it'll be increased to 3?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean the cronos module? I think if there's nothing to migrate in the storage, there's no need to increase the consensus version, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant the ibc-go fork. ConsensusVersion in a module should be increased with any state-breaking changes, so hopefully it's fine