-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: cosmovisor in test is out dated #1380
Conversation
WalkthroughThis update orchestrates the integration of Changes
Recent Review StatusConfiguration used: CodeRabbit UI Files selected for processing (8)
Files skipped from review as they are similar to previous changes (7)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
new version cosmovisor support graceful shutdown Solution: - update cosmovisor - adapt the test case Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1380 +/- ##
===========================================
- Coverage 36.55% 16.47% -20.09%
===========================================
Files 129 80 -49
Lines 9597 5124 -4473
===========================================
- Hits 3508 844 -2664
+ Misses 5712 4204 -1508
+ Partials 377 76 -301 |
259d802
to
fb1a4ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, didn't realize cosmovisor is this old
it was in SDK 0.45 |
5c31fe0
* Problem: cosmovisor in test is out dated (#1380) new version cosmovisor support graceful shutdown Solution: - update cosmovisor - adapt the test case Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> * Problem: rocksdb wal format sometimes not backward compatible (#1379) Solution: - flush the wal before quit the node, make the rocksdb upgrade smooth. Update CHANGELOG.md Signed-off-by: yihuang <huang@crypto.com> fix flush Signed-off-by: yihuang <huang@crypto.com> * Problem: upgrade test nix package is incorrect (#1384) --------- Signed-off-by: yihuang <huang@crypto.com>
new version cosmovisor support graceful shutdown
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
upgrade-test-package
configuration to correctly include specific versions and directories.cosmovisor start
command tocosmovisor run start
in integration tests for enhanced functionality.cosmos-sdk
entry from sources, streamlining the build process.