Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a new route for supporting a secondary bucket #27

Merged
merged 6 commits into from
Sep 2, 2021
Merged

Added a new route for supporting a secondary bucket #27

merged 6 commits into from
Sep 2, 2021

Conversation

som-poddar
Copy link
Contributor

  • Ad crunchyroll, we would like to extend this utility to support avod streaming in the platform.
  • This change adds this capability with the minimal amount of change
    to the existing functionality.
  • Updated to use aws sdk for s3 get call

@som-poddar som-poddar self-assigned this Jul 22, 2021
rmikhael
rmikhael reviewed Jul 22, 2021
View reviewed changes
@mskariah1942
Copy link

@som-poddar where are the unit tests?

rmikhael
rmikhael previously approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@rmikhael rmikhael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mlevkov
mlevkov suggested changes Jul 23, 2021
View reviewed changes
@som-poddar
Added a new route for supporting a secondary bucket
69757db 
- crunchyroll would like to extend this utility to support avod
streaming in the platform.

- This change adds this capability with the minimal amount of change
to the existing functionality.

- Updated to use aws sdk for s3 get call
@som-poddar som-poddar force-pushed the support-multiple-buckets-2 branch from 6d37b08 to 69757db Compare July 26, 2021 18:30
@som-poddar som-poddar mentioned this pull request Jul 26, 2021
Open
@mlevkov
Copy link

mlevkov commented Jul 27, 2021

please consider adding unit tests, positive and negative, even if it is a mocked payload. Please test this thoroughly in Proto0.

@mskariah1942
Copy link

Since this PR is now more than 20 days, are we still waiting to get unit tests in? Let me know if there are concerns or any discussion needed. Thanks!

@som-poddar som-poddar added question and removed ready labels Aug 30, 2021
@som-poddar som-poddar added ready and removed question labels Sep 1, 2021
mlevkov
mlevkov approved these changes Sep 1, 2021
View reviewed changes
Copy link

@mlevkov mlevkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please make a ticket where we can make a generic ability for access to "any" bucket in s3

rmikhael
rmikhael reviewed Sep 1, 2021
View reviewed changes
rmikhael
rmikhael approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@rmikhael rmikhael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Would have preferred a package name more oriented to s3client rather than the generic awsclient, given that we only mock the S3 interface. But not blocking for me.

@som-poddar som-poddar merged commit 38c797f into master Sep 2, 2021
@som-poddar som-poddar deleted the support-multiple-buckets-2 branch September 2, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlevkov mlevkov mlevkov approved these changes

@rmikhael rmikhael rmikhael approved these changes

Assignees

@som-poddar som-poddar

Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@som-poddar @mskariah1942 @mlevkov @rmikhael